Backport remote read fix to release 1.19 #7031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! |
SungJin1212
approved these changes
Sep 21, 2025
friedrichg
approved these changes
Sep 21, 2025
Signed-off-by: yeya24 <benye@amazon.com>
Signed-off-by: Daniel Sabsay <sabsay@adobe.com> Co-authored-by: Daniel Sabsay <sabsay@adobe.com>
|
I have to cherry-pick #6584 to make the build working as Github doesn't support ubuntu 20.04 runner anymore |
friedrichg
approved these changes
Oct 12, 2025
damnever
reviewed
Oct 13, 2025
| // Check if we need to parse the query string to avoid parsing twice. | ||
| shouldReportSlowQuery := f.cfg.LogQueriesLongerThan != 0 && queryResponseTime > f.cfg.LogQueriesLongerThan | ||
| if shouldReportSlowQuery && !f.cfg.QueryStatsEnabled { | ||
| queryString = f.parseRequestQueryString(r, buf) |
There was a problem hiding this comment.
Should we also ignore remote_read if frontend.log-queries-longer-than is enabled?
There was a problem hiding this comment.
Oh, I see.. this is beneath the round trip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Backport #7025 fix to 1.19 release and prepare for 1.19.1 release.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]